MakeCalledArgs allocates a struct tuple #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oopsie doopsie daisy, this won't won't do |
|
Can't we just use X and Y separately? Then you also don't need to snd on it. |
pirrmann
reviewed
May 18, 2020
| @@ -564,3 +564,4 @@ type MaybeLazy<'T> = | |||
| | Strict x -> x | |||
| | Lazy x -> x.Force() | |||
|
|
|||
| let inline vsnd ((_, y): struct('T * 'T)) = y | |||
There was a problem hiding this comment.
why the ('T*'T) here and not ('a*'b) ?
There was a problem hiding this comment.
Agreed, this should be ('a * 'b) or ('T * 'U).
|
mhm just looked at it a bit deeper. Position is used in a SortBy and therefore we would probably have to tuple again anway |
|
Yep, this is probably the most minimal/straightforward change if we're interested in knocking down the (small) amount of needless allocations |
KevinRansom
approved these changes
May 26, 2020
TIHan
approved these changes
May 26, 2020
TIHan
reviewed
May 26, 2020
| @@ -821,7 +821,7 @@ let OutputPhasedErrorR (os: StringBuilder) (err: PhasedDiagnostic) (canSuggestNa | |||
| let nameOrOneBasedIndexMessage = | |||
| x.calledArg.NameOpt | |||
| |> Option.map (fun n -> FSComp.SR.csOverloadCandidateNamedArgumentTypeMismatch n.idText) | |||
| |> Option.defaultValue (FSComp.SR.csOverloadCandidateIndexedArgumentTypeMismatch ((snd x.calledArg.Position) + 1)) | |||
| |> Option.defaultValue (FSComp.SR.csOverloadCandidateIndexedArgumentTypeMismatch ((Lib.vsnd x.calledArg.Position) + 1)) //snd | |||
There was a problem hiding this comment.
Should we always be qualified with Lib? Is that how other functions from Lib are called elsewhere?
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* MakeCalledArgs allocates a struct tuple * Add vsnd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a trace from here: https://developercommunity.visualstudio.com/content/problem/1035124/trace-of-editing-experience-with-in-memory-cross-p-1.html
I found what looked like needless allocations of a tuple of two integers:
This seemed like a needless tupling of two ints, though the values are contained within a larger record that's going on the heap anyways. But in my own testing struct tuples, when it's just things like two ints, is almost always faster for the CPU anyways